From 2ca5ddf53e72379169ab3eb26468a3baa76b0b38 Mon Sep 17 00:00:00 2001 From: Christian Cleberg Date: Thu, 23 Jul 2026 19:38:59 -0500 Subject: docs cleanup --- Docs/ACCESSIBILITY_VERIFICATION.md | 346 --------------------- Docs/ACCESSIBILITY_VERIFICATION_RESULTS.md | 292 ----------------- Docs/a11y-screenshots/classic-batch-axxxl.png | Bin 550245 -> 0 bytes Docs/a11y-screenshots/classic-batch-dark.png | Bin 538266 -> 0 bytes Docs/a11y-screenshots/classic-batch-light.png | Bin 511124 -> 0 bytes Docs/a11y-screenshots/classic-dashboard-axxxl.png | Bin 682095 -> 0 bytes Docs/a11y-screenshots/classic-dashboard-dark.png | Bin 458789 -> 0 bytes Docs/a11y-screenshots/classic-dashboard-light.png | Bin 432824 -> 0 bytes Docs/a11y-screenshots/classic-watchlist-axxxl.png | Bin 335733 -> 0 bytes Docs/a11y-screenshots/lg-batch-axxxl.png | Bin 545064 -> 0 bytes Docs/a11y-screenshots/lg-batch-dark.png | Bin 526559 -> 0 bytes Docs/a11y-screenshots/lg-batch-light.png | Bin 559571 -> 0 bytes Docs/a11y-screenshots/lg-dashboard-axxxl.png | Bin 660915 -> 0 bytes Docs/a11y-screenshots/lg-dashboard-dark.png | Bin 350139 -> 0 bytes .../lg-dashboard-light-differentiate.png | Bin 382492 -> 0 bytes Docs/a11y-screenshots/lg-dashboard-light.png | Bin 376900 -> 0 bytes Docs/a11y-screenshots/lg-watchlist-axxxl.png | Bin 291824 -> 0 bytes SECURITY.md | 6 +- 18 files changed, 3 insertions(+), 641 deletions(-) delete mode 100644 Docs/ACCESSIBILITY_VERIFICATION.md delete mode 100644 Docs/ACCESSIBILITY_VERIFICATION_RESULTS.md delete mode 100644 Docs/a11y-screenshots/classic-batch-axxxl.png delete mode 100644 Docs/a11y-screenshots/classic-batch-dark.png delete mode 100644 Docs/a11y-screenshots/classic-batch-light.png delete mode 100644 Docs/a11y-screenshots/classic-dashboard-axxxl.png delete mode 100644 Docs/a11y-screenshots/classic-dashboard-dark.png delete mode 100644 Docs/a11y-screenshots/classic-dashboard-light.png delete mode 100644 Docs/a11y-screenshots/classic-watchlist-axxxl.png delete mode 100644 Docs/a11y-screenshots/lg-batch-axxxl.png delete mode 100644 Docs/a11y-screenshots/lg-batch-dark.png delete mode 100644 Docs/a11y-screenshots/lg-batch-light.png delete mode 100644 Docs/a11y-screenshots/lg-dashboard-axxxl.png delete mode 100644 Docs/a11y-screenshots/lg-dashboard-dark.png delete mode 100644 Docs/a11y-screenshots/lg-dashboard-light-differentiate.png delete mode 100644 Docs/a11y-screenshots/lg-dashboard-light.png delete mode 100644 Docs/a11y-screenshots/lg-watchlist-axxxl.png diff --git a/Docs/ACCESSIBILITY_VERIFICATION.md b/Docs/ACCESSIBILITY_VERIFICATION.md deleted file mode 100644 index 4788844..0000000 --- a/Docs/ACCESSIBILITY_VERIFICATION.md +++ /dev/null @@ -1,346 +0,0 @@ -# Accessibility Verification Checklist (issue #21, Phase 6) - -Manual verification for the accessibility work in phases 1–5. Everything here is -what the automated audit (`Scripts/audit-a11y.sh`) **cannot** check: VoiceOver -speech, the rotor, custom-content ordering, announcements, Voice Control, -motion/transparency/colour settings, keyboard focus order, and the two system -design languages. A green audit is necessary, not sufficient — this is what makes -it sufficient. - -Each item traces to the phase that introduced it (e.g. `[P4]`) so a failure points -straight at the code. Check the box only when the **Expected** line is literally -true on the device. - ---- - -## 0. Setup - -### Devices / runtimes - -The app supports **iOS 17.6+** and renders under two system design languages: -classic chrome (17.6–25) and Liquid Glass (26+). Materials, surfaces, and -contrast resolve differently between them, so visual passes need both. - -- [ ] Primary device on **iOS 26+** (Liquid Glass). -- [ ] A device or simulator on the **floor** (oldest available ≥ 17.6; 18.x is - the practical minimum since no 17.6 runtime ships). A simulator is fine for - the visual and Dynamic Type passes; VoiceOver/Voice Control are best on - hardware. - -### Seed data — required, or half the checklist is untestable - -Several items only render with tracked domains and a completed lookup. The audit -simulator has none, which is exactly why the dense rows and widget are unverified -so far. Before starting: - -- [ ] Inspect tab → run a lookup on a **live** domain (e.g. `cleberg.net`), let - all sections load. -- [ ] Run a lookup on a domain with a **weak/expiring or missing** cert and - missing SPF/DMARC, so warning/critical tones and badges actually appear. -- [ ] Track **at least 4** domains with mixed health (one healthy, one warning, - one critical, one unreachable) so Dashboard tiles, dense watchlist rows, and - the widget all have content. -- [ ] Run a **Bulk** lookup on ~5 domains so `BatchResultRowView` renders. -- [ ] Add the **Domain Portfolio** widget to the Home Screen in all three sizes - (small, medium, large). -- [ ] Force the Pro tier if needed so gated screens (Workflows, Scheduled - Reports, Compare) are reachable. - -### Settings map (paths used throughout) - -| Setting | Path | -| --- | --- | -| VoiceOver | Settings → Accessibility → VoiceOver | -| Screen Curtain | VoiceOver on → triple-tap with 3 fingers | -| Voice Control | Settings → Accessibility → Voice Control | -| Larger Text / Dynamic Type | Settings → Accessibility → Display & Text Size → Larger Text | -| Bold Text | Settings → Accessibility → Display & Text Size → Bold Text | -| Increase Contrast | Settings → Accessibility → Display & Text Size → Increase Contrast | -| Differentiate Without Color | Settings → Accessibility → Display & Text Size → Differentiate Without Color | -| Smart Invert | Settings → Accessibility → Display & Text Size → Smart Invert | -| Reduce Motion | Settings → Accessibility → Motion → Reduce Motion | -| Reduce Transparency | Settings → Accessibility → Display & Text Size → Reduce Transparency | -| Full Keyboard Access (iPad) | Settings → Accessibility → Keyboards → Full Keyboard Access | -| App appearance override | In-app: Settings tab → Display → Appearance | - -> Ordering note: the passes are grouped so each iOS setting is toggled **once**. -> Do them top to bottom to avoid thrashing Settings. - ---- - -## 1. Baseline visual — Light, Dark, System `[P1][P2]` - -No assistive tech on. Toggle appearance via **in-app Settings → Display → -Appearance**, then confirm the system setting is also honoured. - -- [ ] **System** appearance follows the device; flipping the device Light/Dark - flips the app. -- [ ] **Light** and **Dark** overrides hold regardless of the device setting. -- [ ] Accent is **blue** everywhere — tab bar selection, links, section titles' - "info" accents, the Insights icons, the selected quick-filter chip. No - leftover **cyan**. `[P1]` -- [ ] Warning tone reads as **orange**, not olive/brown — check a "Warning" or - "Expiring" badge and the Dashboard "Warning" tile. `[P1 rebalance]` -- [ ] The selected Dashboard summary tile is a soft **blue-tinted** surface, not - lavender/violet. `[P2 wash fix]` -- [ ] Prominent buttons (**Run**, **Run Batch**, **Scan**) show a **white label - on a blue fill** that is comfortably readable in both schemes. `[P1 AccentFill]` -- [ ] Secondary/detail text (row labels, timestamps, "Monitoring off") is legible - in **Light** — not washed-out grey. `[P2 AppTextSecondary]` -- [ ] Status badges pair an **icon + text + colour** (e.g. lock + "Valid"), - never colour alone. -- [ ] Repeat the whole list on the **floor runtime**. Note any Liquid-Glass-only - difference. `[cross-runtime]` - ---- - -## 2. Dynamic Type & reflow — up to Accessibility 5 `[P3]` - -Larger Text → drag to **maximum** (AX5). Walk every primary screen: Inspect -(with results), Dashboard, Audit, History, Settings, Watchlist, a tracked-domain -detail, Workflows. - -- [ ] All body text **scales up** (it already did pre-P3; confirm nothing is - pinned). The Dashboard tile numbers scale too. `[P3 fixed .system(size:)]` -- [ ] **No clipped headings.** Empty-state titles ("No Portfolio Yet", "No Audits - Yet", "No History Yet", "No Tracked Domains", "No Batch Results Yet") **wrap - onto multiple lines** rather than truncating with "…". `[P3 Label→HStack]` -- [ ] **No card requires horizontal scrolling.** Inspect result cards, the risk - card, and detail rows **wrap vertically**; there is no hidden left-right - gesture to reach content. `[P3 CardView reflow]` -- [ ] Dense rows (`BatchResultRowView`, `WatchlistRowView`) remain **readable** — - text may be tall but must not overlap the trailing badge or clip. If it - does, that is the deferred `ViewThatFits` work, not a P3 regression — log it. - `[deferred]` -- [ ] Every tappable control is at least **44×44pt** at default size. Spot-check - the **copy buttons** on data rows (the most-repeated control), the - **collapsible section headers**, and **Run**. `[P3 tap targets]` -- [ ] Turn on **Bold Text**; confirm no layout breaks and contrast holds. -- [ ] **Widget**: at AX sizes the widget content stays readable and is **not - truncated into nonsense** — it clamps at Accessibility 1 by design. `[P3 widget clamp]` -- [ ] Repeat the clipping/reflow spot-checks on the **floor runtime**. - ---- - -## 3. VoiceOver `[P4]` - -Enable VoiceOver. Learn the gestures if needed: swipe right = next element, swipe -up/down on the **rotor** set to "More Content" = reveal extra fields, two-finger -swipe up = read from top. - -### 3a. Icon-only controls announce a purpose, not a symbol name - -Focus each and confirm the spoken label. **None** should say a raw symbol name -("arrow clockwise", "square and arrow up", "bolt circle"). - -- [ ] Dashboard toolbar refresh → **"Refresh all tracked domains"**. -- [ ] Inspect toolbar (after a lookup): clear → **"Clear results"**; actions menu - → **"Actions"**; export menu → **"Export"**. -- [ ] Watchlist: add → **"Add domain"**; filter → **"Filter and sort"**. -- [ ] History filter → **"Filter"**. -- [ ] Timeline grouping → **"Group timeline"**. -- [ ] Workflows: create → **"Create workflow"**; a run summary's export → - **"Export summary"**; re-run → **"Re-run workflow"**; a shared workflow's - person icon → **"Shared"**. - -### 3b. Toggles announce their state - -- [ ] Inspect **Save** (bookmark): label **"Save domain"**, value **"Not saved"**; - activate → value becomes **"Saved"** and the element reports **selected**. -- [ ] Domain section **Pin**: label **"Pin domain"**, value toggles - **"Pinned"/"Not pinned"** and reports **selected** when pinned. -- [ ] Audit checklist item: reports **selected** when complete, and a **hint** - ("Marks complete" / "Marks incomplete"). -- [ ] Audit area picker and Workflow domain picker rows report **selected** when - chosen. - -### 3c. Badges and headings - -- [ ] A status badge reads as **one word** — "Critical", "Valid", "Secure" — not - "icon, Critical". `[P4 badge combine]` -- [ ] Set the rotor to **Headings**. Section titles ("Summary", "Risk", "DNS", - etc.) and the collapsible Inspect section headers are reachable as headings - and let you **jump between sections**. `[P4 .isHeader]` -- [ ] A collapsible Inspect header announces **"Expanded"/"Collapsed"** as its - value with a hint, and toggling it updates the value. `[P4]` -- [ ] Confirm the header's **trailing controls** (Track / Pin / Note on the Domain - section) are still **individually focusable** — they were deliberately *not* - merged into the header. `[P4 no combine on trailing]` - -### 3d. Dense rows — combine + More Content rotor (the flagship) - -On the **Watchlist** and a **Bulk** result list, with the rotor on **More Content**: - -- [ ] Each row is **one VoiceOver stop**, not eight. `[P4]` -- [ ] The row's **label is the domain**; its **value is the status** (e.g. - "Registered" / "Critical, Registered"). -- [ ] Swiping up/down on More Content reveals the extra fields **in order**: - - Watchlist row: **Certificate** (spoken first, high importance), - Monitoring, Updated, Pinned. - - Batch row: **Risk** (high importance), IP address, Checked, Source, - Impact/Status. -- [ ] Risk and Certificate are spoken **without** needing the rotor (high - importance); the rest wait for the swipe. - -### 3e. Speech for technical strings - -- [ ] Focus a **DNS record value** (Inspect → DNS section) and an SSL **Cipher - Suite** (Web section). Punctuation (`;`, `~`, `_`, `-`) is **spoken**, and - the string reads character/token-sensibly rather than as garbled prose. - `[P4 speechStyle .technical]` -- [ ] Focus a plain prose value (e.g. Issuer common name) and confirm it is **not** - spelled out awkwardly — only technical rows get the treatment. - -### 3f. Completion announcements - -- [ ] Run a **single lookup**. On completion VoiceOver speaks **"Lookup complete - for ``. ``."** without you moving focus. `[P4]` -- [ ] Run a **sweep / Check All**. On completion it speaks **"Sweep complete. N - domains, X changed, Y warnings."** `[P4]` -- [ ] The announcements do **not** fire per-domain during a long sweep (would - flood the queue) — only once at the end. - -### 3g. Widget under VoiceOver - -- [ ] A medium/large widget domain row reads as one phrase, e.g. **"example.com, - critical, certificate expires in 12 days"** (or "pinned", or "certificate - expired"). `[P4]` -- [ ] The small widget's count pills read **"N healthy"**, **"N warning"**, - **"N critical"** — not a bare number. `[P4]` - -### 3h. Full walkthrough with Screen Curtain - -Turn on Screen Curtain (triple-tap, 3 fingers — screen goes black). Complete the -core journey **without looking**: - -- [ ] Inspect a domain → hear the sections → **Save** it → open **Watchlist** → - open its **detail** → back out. Every step is discoverable and every control - announces a purpose and state. Log anything that leaves you stuck. - ---- - -## 4. Voice Control — label-in-name (WCAG 2.5.3) `[P4]` - -Enable Voice Control. Say the **printed** text of controls. Every visible-text -control must respond to its visible name (this is why labels preserve visible -text rather than replacing it). - -- [ ] "Tap **Run**" runs the lookup (not broken by a relabel). -- [ ] "Tap **Track**", "Tap **Note**", "Tap **Compare**", "Tap **Cancel**", - "Tap **Save**" each work by their printed word. -- [ ] Say **"Show numbers"**; confirm the icon-only controls get numbered overlays - and are operable (they have labels, so they also respond to "Show names"). -- [ ] No control is reachable *only* by a name that differs from its visible text. - ---- - -## 5. Colour & contrast settings `[P1][P2][P5]` - -### 5a. Increase Contrast - -- [ ] Enable. Status colours and the accent shift to their **high-contrast** - variants; nothing becomes unreadable in either scheme. `[P1 HC variants]` -- [ ] The Settings section headers that were marginal now clear — this is the one - the audit already measured (light 21 → 18). `[P2]` - -### 5b. Differentiate Without Color — the P5 payoff - -Enable. This is the pass that validates most of Phase 5. - -- [ ] **Dashboard summary tiles**: the small dot becomes a **per-filter symbol** - (grid, checkmark, triangle, octagon, refresh, clock, wifi-slash). `[P5]` -- [ ] **Selected quick-filter chip** gains a **checkmark + border** — selection no - longer depends on fill colour alone. `[P5]` -- [ ] **Inspect data rows** with a warning/failure value show a **leading symbol** - (triangle / octagon) before the value. `[P5 LabeledValueRow]` -- [ ] Turning the setting **off** removes those extras (no permanent clutter). `[P5]` -- [ ] **Widget** status already uses symbols regardless of this setting — confirm - each row shows checkmark/triangle/octagon, not a bare dot. `[P5]` - -### 5c. Smart Invert - -- [ ] Enable. UI inverts sensibly; images/icons that should stay un-inverted do. - Text stays legible. Note anything that inverts wrongly. `[verification]` - ---- - -## 6. Motion & transparency `[P5]` - -### 6a. Reduce Motion - -Enable. Confirm each animated transition becomes an **instant** state change (no -slide/fade): - -- [ ] Copy button check-mark swap (tap a copy button) — flips instantly. `[P5]` -- [ ] Collapsible Inspect section expand/collapse — no ease animation. `[P5]` -- [ ] Timeline scroll-to-section — jumps, no scroll animation. `[P5]` -- [ ] Watchlist list reorder (change sort/filter) — no reflow animation. `[P5]` - -### 6b. Reduce Transparency - -- [ ] Enable. Trigger the **Data Management** success toast (Settings → Data - Management → perform a clear). Its pill background is an **opaque surface**, - not a blur. `[P5]` -- [ ] On **iOS 26+**, confirm system-composited chrome (nav/tab bars) still reads - acceptably — the app can't declare that translucency itself. `[cross-runtime]` - ---- - -## 7. iPad — Full Keyboard Access & split layout `[verification]` - -On iPad (regular width, so `RootTabView` shows the `NavigationSplitView` -sidebar + detail). Enable Full Keyboard Access; attach or use the software -alternative. - -- [ ] **Tab** moves focus in a **logical order** — sidebar → detail, top → bottom, - no traps. -- [ ] The blue **focus ring** is visible on every focusable control. -- [ ] Sidebar tab selection and detail controls are all reachable and operable by - keyboard. -- [ ] Switching tabs via keyboard updates the detail pane correctly. - ---- - -## 8. Cross-runtime sign-off `[cross-runtime]` - -- [ ] Sections 1, 2, 5, 6 re-checked on the **floor runtime** (classic chrome). -- [ ] Sections 1, 2, 5, 6 checked on **iOS 26+** (Liquid Glass). -- [ ] Any behaviour that differs between the two is logged below with the runtime - noted. - ---- - -## Sign-off - -| Pass | 26+ (Liquid Glass) | Floor (classic) | Notes | -| --- | --- | --- | --- | -| 1 Baseline visual | | | | -| 2 Dynamic Type / reflow | | | | -| 3 VoiceOver | n/a-runtime | | do once on hardware | -| 4 Voice Control | n/a-runtime | | do once on hardware | -| 5 Colour & contrast | | | | -| 6 Motion & transparency | | | | -| 7 iPad keyboard | n/a | | iPad only | - -## Defect log - -Record failures here; each becomes an issue or a fix commit. - -| # | Pass / item | Device / runtime | Observed | Expected | Traces to | -| --- | --- | --- | --- | --- | --- | -| | | | | | | - ---- - -## Known-deferred (not defects — expected gaps) - -- **`ViewThatFits` dense-row reflow** was not implemented (unverifiable in the - audit sim). If §2 shows dense rows overlapping/truncating at AX5 with real data, - that is this gap surfacing — file it against the deferred item, don't treat it - as a P3 regression. -- **Live Activity / Dynamic Island** custom accessibility was intentionally not - added (ActivityKit exposes the labelled `ProgressView` already). Sanity-check a - running sweep's Live Activity reads acceptably, but a finding here is - enhancement, not regression. -- **Localization** — all strings are English literals by design for now; a11y - strings were written `LocalizedStringKey`-compatible for a future catalog. diff --git a/Docs/ACCESSIBILITY_VERIFICATION_RESULTS.md b/Docs/ACCESSIBILITY_VERIFICATION_RESULTS.md deleted file mode 100644 index 46ae878..0000000 --- a/Docs/ACCESSIBILITY_VERIFICATION_RESULTS.md +++ /dev/null @@ -1,292 +0,0 @@ -# Accessibility Verification — Results (issue #21, Phase 6) - -Execution of `ACCESSIBILITY_VERIFICATION.md` against the iOS Simulator. The -runbook was written for a human on a physical device; a meaningful fraction is -beyond a simulator. Every item below is sorted into one of three tiers and -treated accordingly: - -- **Tier 1 — executed here.** Appearance, Increase Contrast, Dynamic Type - (including a middle-band sweep), the audit suite, accessibility **metadata** - (labels/values/traits, now permanent XCUITest assertions), and the - Liquid-Glass-vs-classic cross-runtime comparison. -- **Tier 2 — attempted, reported honestly.** Differentiate Without Color, - Reduce Motion, Reduce Transparency. One of the three turned out to be fully - toggleable and is now **verified**; the mechanism is documented for the rest. -- **Tier 3 — requires a physical device.** VoiceOver speech, the rotor, - announcements, Voice Control, Screen Curtain. Not attempted, not faked. - -**"Verified" vs "verified by construction."** A ✅ **Pass** means the behaviour -was *observed* (a screenshot, an assertion, or a finding-count delta). *Verified -by construction* (⚙️) means the code compiles and the pattern is right but the -runtime behaviour was not observed here — it is **not** counted as a pass. - -## Environment - -| Role | Simulator | Runtime | Design language | -| --- | --- | --- | --- | -| Floor | iPhone 16 | iOS 18.6 | Classic chrome | -| Liquid Glass (mid) | iPhone 17 | iOS 26.5 | Liquid Glass | -| Current | iPhone 17e | iOS 27.0 | Liquid Glass | - -Deployment target is 17.6; no 17.6/17.5 runtime is usable (the app cannot -install below the floor), so 18.6 is the practical floor, per the runbook. - -Seed data via `DOMAIN_DIG_SEED_FIXTURES` + `DOMAIN_DIG_FORCE_PRO_PLUS` (DEBUG, -in-memory, never persisted). **Note on tooling:** `simctl launch` with the seed -argument did *not* populate the fixtures, and `simctl ui appearance` did not -propagate to a headless-booted simulator. Both were worked around by driving -everything through **XCUITest** (which seeds reliably) and switching appearance -through the app's own Settings → Display picker. This is why the screenshots and -metadata checks are committed as tests rather than shell scripts — see -`DomainDigUITests/AccessibilityScreenshotTests.swift` and -`AccessibilityMetadataTests.swift`. - ---- - -## Headline outcomes - -1. **A real enforced failure was found and fixed.** `Scripts/audit-a11y.sh - current` (iOS 27.0) failed an **enforced** `.dynamicType` finding on the - Settings `Section("Services")` header — a system-rendered header the app sets - no font on, present only on 27.0 (18.6 floor and the 26.x runtime CI uses are - clean). Resolved with a narrow, proven `noiseReason(for:)` carve-out. Delta: - `current` went **FAIL → SUCCEEDED**, the finding still printed as - `[noise: …]`. See §5 and the fix note below. -2. **The highest-value metadata checks are now permanent tests.** The dense-row - label/value contracts and the icon-only control labels are asserted - mechanically in `AccessibilityMetadataTests` (green on 18.6 and 27.0), - shrinking the manual runbook. -3. **Differentiate Without Color is fully verifiable in the simulator** via the - *global* `com.apple.Accessibility` defaults domain — the runbook and task - both assumed this might not be reachable. It is. Captured proof: - `lg-dashboard-light-differentiate.png`. -4. **The middle-band Dynamic Type sweep found no third bug** exclusive to that - band (negative result), but is retained as regression insurance for a band - that historically shipped two. - ---- - -## 1. Baseline visual — Light, Dark, System `[P1][P2]` - -Evidence: `classic-dashboard-{light,dark}.png`, `lg-dashboard-{light,dark}.png`, -`classic-batch-{light,dark}.png`, `lg-batch-{light,dark}.png`. Appearance driven -through Settings → Display. - -| Item | Result | Notes | -| --- | --- | --- | -| System follows device | ⚙️ By construction | `simctl ui appearance` does not propagate headlessly; Light/Dark set via the in-app picker instead, which drives the same single `@AppStorage` path. | -| Light / Dark overrides hold | ✅ Pass | Both captured on both runtimes; the picker override renders correctly. | -| Accent blue everywhere, no cyan | ✅ Pass | Tab-bar selection, `•All`, links, selected quick-filter chip all blue. No cyan observed. | -| Warning reads orange, not olive | ✅ Pass | Dashboard "Warning" tile and batch "Warning" badge are clearly orange in both schemes. | -| Selected tile is blue-tinted, not lavender | ✅ Pass | "Total Domains" tile is a soft blue surface in light and dark. | -| Prominent buttons: white label on blue fill | ⚙️ By construction | Run/Run Batch are disabled in the seeded state (no typed domain), so the enabled `.borderedProminent` fill was not captured; palette values are audited. | -| Secondary text legible in Light | ✅ Pass | "QUICK FILTERS", timestamps, "No recent portfolio changes" read clearly on the light card (this is the `AppTextSecondary` fix). | -| Badges pair icon + text + colour | ✅ Pass | Batch badges show lock/triangle/octagon/x + word + colour. | -| Repeat on floor runtime | ✅ Pass | Classic-chrome (18.6) captures match; see cross-runtime §8. | - -## 2. Dynamic Type & reflow — up to Accessibility 5 `[P3]` - -Evidence: `*-dashboard-axxxl.png`, `*-batch-axxxl.png`, `*-watchlist-axxxl.png` -(both runtimes), plus the automated `…AccessibilityXXXL` and new -`…AccessibilityL` audit sweeps. - -| Item | Result | Notes | -| --- | --- | --- | -| Body text + tile numbers scale | ✅ Pass | Dashboard "4 / 2 / 1" and all labels scale at AXXXL. | -| No clipped headings (wrap, not "…") | ✅ Pass | "Batch Results", "Total Domains" wrap onto multiple lines; audit reports no *named* `textClipped` on empty-state headings. | -| No card needs horizontal scrolling | ✅ Pass | Cards reflow vertically at AXXXL; no hidden horizontal gesture. | -| Dense rows readable at AX5 | ⚠️ Known-deferred | Watchlist/batch rows become very tall and wrap; readable, no horizontal badge overlap. This is the deferred `ViewThatFits` case, **not** a P3 regression (see `lg-watchlist-axxxl.png`). | -| Tap targets ≥ 44×44 | ⚙️ By construction | `AppLayout.minimumTapTarget` floor is enforced in code and the audit reports no named `hitRegion` findings; not separately measured here. | -| Bold Text | ❌ Not executed | Not exposed by `simctl`; same class as the Tier-2 settings. Requires device or Settings-app automation. | -| Widget clamps at AX1 | ❌ Not executed | Widgets do not render in the audit simulator or these captures — Tier 3-adjacent (needs Home Screen). | -| Repeat spot-checks on floor | ✅ Pass | Classic AXXXL captures match. | - -**Middle-band sweep (added).** `testSeededScreensAtIntermediateAccessibilitySize` -audits the seeded screens at `AccessibilityL`. Result: the `textClipped` findings -it surfaced on the Risk badges (`Risk 12 Low`, `Risk 41 Medium`) are **also -present at the default size** and absent at XXXL, so they are pre-existing -reportOnly seeded-row findings, **not** a middle-band-exclusive third bug. No new -gap found. The sweep is retained as regression insurance for a band that -historically shipped two escaped bugs. - -## 3. VoiceOver `[P4]` — Tier 3, requires a physical device - -iOS VoiceOver **speech** does not run in the Simulator; macOS VoiceOver reading -the simulator window is not equivalent and is not accepted as evidence. What the -simulator *can* assert is the underlying **metadata**, which is now covered by -`AccessibilityMetadataTests` (green on 18.6 and 27.0): - -| Runbook item | Metadata coverage | Result | -| --- | --- | --- | -| §3a Dashboard refresh → "Refresh all tracked domains" | asserted | ✅ Pass | -| §3a Watchlist add → "Add domain"; filter → "Filter and sort" | asserted | ✅ Pass | -| §3a Workflows create → "Create workflow" | asserted | ✅ Pass | -| §3a History filter → "Filter" | ⚙️ By construction | Menu is gated behind non-empty history; not seedable. Label exists at `HistoryView.swift:109`. | -| §3a Inspect clear/actions/export, Timeline grouping, Workflow export/re-run/shared | ⚙️ By construction | Reachable only after a live lookup / on populated workflow runs; labels verified in source (see `ACCESSIBILITY.md` map). | -| §3d Watchlist row: label = domain, value = availability | asserted | ✅ Pass (`healthy.example`→"Registered"; long domain→"Unknown") | -| §3d Batch row: label = domain, value = "status, availability" | asserted | ✅ Pass (`broken.example`→"Critical, Registered"; `unreachable.example`→"Failed, Unknown") | -| §3c Badge reads as one word | asserted (folded into row value) | ✅ Pass | -| §3b Save/Pin selected-state; §3b audit checklist; picker selected | ⚙️ By construction | All live behind a completed live inspection, seeded audits, or a multi-step gated flow — non-deterministic in CI. Traits verified in source (`ContentView.swift:565–567, 1372–1374`; `AuditViews.swift:264–265`; `WorkflowsView.swift:647`). | -| §3e speech style, §3f announcements, §3g widget speech, §3h Screen Curtain | ❌ Requires device | VoiceOver speech / rotor / announcements — Tier 3. | - -**Rotor / custom-content ordering:** not observable from XCUITest at all — -`.accessibilityCustomContent` does not surface as a queryable element property. -Verified by construction (the `WatchlistRowAccessibility` / -`BatchRowAccessibility` modifiers) and deferred to the device pass. - -## 4. Voice Control (WCAG 2.5.3) `[P4]` — Tier 3, requires a physical device - -Voice Control does not run in the Simulator. Label-in-name is partially -*inferable* — every asserted `accessibilityLabel` in §3 preserves the control's -visible text — but "say the printed word and it activates" must be confirmed on -hardware. - -| Item | Result | -| --- | --- | -| "Tap Run / Track / Note / Compare / Cancel / Save" by printed word | ❌ Requires device | -| "Show numbers" overlays on icon-only controls | ❌ Requires device | -| No control reachable only by a differing name | ⚙️ By construction (labels preserve visible text) | - -## 5. Colour & contrast settings `[P1][P2][P5]` - -### 5a. Increase Contrast — Tier 1 - -`simctl ui increase_contrast enabled` works. The palette carries HC -variants; the audit's `.contrast` category stays report-only by design (see -`ACCESSIBILITY.md`). - -| Item | Result | Notes | -| --- | --- | --- | -| Status/accent shift to HC variants, nothing unreadable | ⚙️ By construction | HC toggles via `simctl`, but the effect is a colour-value swap not reliably distinguishable in a downscaled screenshot; palette HC variants are defined and audited. | -| Marginal Settings headers clear | ⚙️ By construction | The documented light 21→18 contrast measurement; unchanged this pass. | - -### 5b. Differentiate Without Color — **Tier 2, VERIFIED** ✅ - -The runbook and task both flagged this as possibly un-toggleable in a simulator. -It **is** toggleable: `simctl ui` does not expose it, and a `defaults write` to -the app's *own* (sandboxed) container does not reach it — but a write to the -**global** `com.apple.Accessibility` domain does, and XCUITest-launched apps read -it via `UIAccessibility`: - -```sh -xcrun simctl spawn defaults write com.apple.Accessibility DifferentiateWithoutColor -bool true -``` - -Captured proof — `lg-dashboard-light-differentiate.png` vs `lg-dashboard-light.png`: - -| Item | Result | Observed | -| --- | --- | --- | -| Summary tiles gain per-filter symbols | ✅ Pass | Dot → grid (All), checkmark (Healthy), triangle (Warning), octagon (Critical), refresh (Changed), wifi-slash (Unreachable). | -| Selected quick-filter chip gains checkmark + border | ✅ Pass | "All" chip shows ✓ and a border; selection no longer fill-colour only. | -| Inspect data-row warning/failure symbol | ⚙️ By construction | `LabeledValueRow` is behind a live lookup; the Dashboard payoff above exercises the same `accessibilityDifferentiateWithoutColor` path. | -| Turning it off removes the extras | ✅ Pass | The default set of screenshots (setting off) shows plain dots / no chip checkmark. | -| Widget uses symbols regardless | ⚙️ By construction | Widget does not render in these captures. | - -### 5c. Smart Invert — ❌ Not executed - -Not exposed by `simctl`; not in the global-domain set that worked for DWC. -Requires the Settings app / device. - -## 6. Motion & transparency `[P5]` — Tier 2 - -Both settings **can be written** to the global `com.apple.Accessibility` domain -(`ReduceMotionEnabled`, `ReduceTransparencyEnabled`) — the same mechanism proven -to reach the app for DWC. But their *effects* are not screenshot-capturable: - -| Item | Result | Notes | -| --- | --- | --- | -| §6a Reduce Motion: copy-check swap, section expand, timeline scroll, list reorder become instant | ⚙️ By construction | Effect is animation *timing*; a still frame cannot show "instant vs animated". Toggle mechanism confirmed; five sites guarded via `accessibilityReduceMotion` in code. | -| §6b Reduce Transparency: Data Management toast is opaque | ⚙️ By construction | The only translucency swap is a **transient** toast behind a multi-step clear; not captured. `accessibilityReduceTransparency` swap verified in source. | -| §6b iOS 26+ system chrome still reads acceptably | ✅ Pass | Liquid Glass nav/tab bars legible in all captures (app cannot declare that translucency itself). | - -**Net:** the Tier-2 toggle method (global accessibility defaults + XCUITest -launch) is now known to work — DWC is fully verified with it. Motion and -Transparency remain verified-by-construction because their effects are timing / -transient, but the manual device pass for them is now optional rather than -blocked: the same `defaults write` unblocks a scripted check with a screen -recording. - -## 7. iPad — Full Keyboard Access & split layout `[verification]` - -| Item | Result | -| --- | --- | -| Tab focus order, focus ring, sidebar/detail reachability, tab→detail update | ❌ Requires device | Full Keyboard Access is not exposed by `simctl`; keyboard-focus traversal is a hardware/Settings behaviour. The `NavigationSplitView` layout itself renders (regular width) but focus order was not exercised. | - -## 8. Cross-runtime sign-off `[cross-runtime]` - -Captured the same seeded screens on **classic chrome (18.6)** and **Liquid Glass -(26.5)** in Light, Dark, and AXXXL. The audit was run on **18.6 and 27.0**. - -- The semantic palette resolves correctly on both design languages: warning - orange, critical red, positive green, blue accent, blue-tinted selected tile. - No Liquid-Glass-only palette regression observed. -- The only structural difference is expected: Liquid Glass renders translucent, - rounded nav/tab chrome; classic renders flatter, opaque chrome. Legibility - holds in both. -- **Audit coverage is genuinely not nested:** 18.6 passed clean; 27.0 surfaced - the extra `Section` header `.dynamicType` finding that 18.6/26.x do not (now - carved out). This confirms the repo's rationale for a per-runtime local run. - ---- - -## Filled sign-off - -| Pass | 26+/27 (Liquid Glass) | Floor (classic 18.6) | Notes | -| --- | --- | --- | --- | -| 1 Baseline visual | ✅ | ✅ | Light/Dark captured both; System by-construction | -| 2 Dynamic Type / reflow | ✅ | ✅ | AXXXL + middle-band L; dense rows known-deferred | -| 3 VoiceOver | metadata ✅ / speech ❌ device | metadata ✅ | Speech/rotor Tier 3 | -| 4 Voice Control | ❌ device | ❌ device | Labels preserve visible text (by construction) | -| 5 Colour & contrast | 5b DWC ✅ / 5a,5c ⚙️/❌ | 5b DWC ✅ | DWC verified via global defaults | -| 6 Motion & transparency | ⚙️ | ⚙️ | Effects not screenshot-capturable | -| 7 iPad keyboard | n/a | ❌ device | FKA not in simulator | - -## Tier 3 — the residual physical-device pass - -The human pass now shrinks to exactly these, all requiring hardware: - -- **VoiceOver:** §3a controls only reachable after a live lookup (Inspect - clear/actions/export, Timeline grouping, Workflow export/re-run/shared); - §3b Save/Pin/audit-checklist/picker selected-state *spoken*; §3c one-word - badge *spoken*; §3d More Content rotor order; §3e technical-string speech; - §3f completion announcements; §3g widget speech; §3h Screen Curtain journey. -- **Voice Control:** §4 in full. -- **Bold Text** (§2), **Smart Invert** (§5c), and the **iPad Full Keyboard - Access** pass (§7) — Settings toggles not exposed to `simctl` and not in the - global accessibility domain. -- **Widget** at AX sizes and under VoiceOver (§2, §3g) — needs the Home Screen. -- **Reduce Motion / Reduce Transparency** *effect* confirmation (§6) — optional; - the toggle is now scriptable, but observing instant-animation / opaque-toast - needs a screen recording. - -## Changes made this pass - -| Change | File | Evidence | -| --- | --- | --- | -| Fixed enforced 27.0 Settings `.dynamicType` failure | `DomainDigUITests/AccessibilityAuditHarness.swift` | `audit-a11y.sh current` FAIL → SUCCEEDED; finding prints as `[noise: iOS-rendered Settings section header …]` | -| New metadata assertions (icon labels, dense-row label/value) | `DomainDigUITests/AccessibilityMetadataTests.swift` | 4 tests green on 18.6 + 27.0 | -| Middle-band Dynamic Type sweep (`AccessibilityL`) | `DomainDigUITests/AccessibilityAuditTests.swift` | Passes; negative result recorded above | -| Screenshot-capture utility (best-effort, non-gating) | `DomainDigUITests/AccessibilityScreenshotTests.swift` | 15 screenshots in `Docs/a11y-screenshots/` | - -### On the suppression (not a ratchet weakening) - -The Settings finding is on a plain `Section("Services")` (`ContentView.swift` -~2768) whose font the app never sets — the scaling is UIKit's system header. It -appears **only** on iOS 27.0 (the 18.6 floor and the 26.x runtime CI runs are -clean; `ACCESSIBILITY.md` already records this asymmetry as "dynamicType finding -18.6 missed"). The carve-out is scoped to `.dynamicType` on the exact Settings -section-header titles, so a real regression on app-controlled text still -enforces — matching the existing "system field placeholder" and system-header -contrast carve-outs. The proof lives inline in `noiseReason(for:)`. - -## Screenshot index (`Docs/a11y-screenshots/`) - -| File | Runtime | Screen | Config | -| --- | --- | --- | --- | -| `classic-dashboard-light.png` / `-dark.png` | 18.6 | Dashboard | Light / Dark | -| `classic-batch-light.png` / `-dark.png` | 18.6 | Batch results | Light / Dark | -| `classic-{dashboard,watchlist,batch}-axxxl.png` | 18.6 | — | AccessibilityXXXL | -| `lg-dashboard-light.png` / `-dark.png` | 26.5 | Dashboard | Light / Dark | -| `lg-batch-light.png` / `-dark.png` | 26.5 | Batch results | Light / Dark | -| `lg-{dashboard,watchlist,batch}-axxxl.png` | 26.5 | — | AccessibilityXXXL | -| `lg-dashboard-light-differentiate.png` | 26.5 | Dashboard | Light + Differentiate Without Color | diff --git a/Docs/a11y-screenshots/classic-batch-axxxl.png b/Docs/a11y-screenshots/classic-batch-axxxl.png deleted file mode 100644 index 954c484..0000000 Binary files a/Docs/a11y-screenshots/classic-batch-axxxl.png and /dev/null differ diff --git a/Docs/a11y-screenshots/classic-batch-dark.png b/Docs/a11y-screenshots/classic-batch-dark.png deleted file mode 100644 index 6c786b6..0000000 Binary files a/Docs/a11y-screenshots/classic-batch-dark.png and /dev/null differ diff --git a/Docs/a11y-screenshots/classic-batch-light.png b/Docs/a11y-screenshots/classic-batch-light.png deleted file mode 100644 index 8c9aa52..0000000 Binary files a/Docs/a11y-screenshots/classic-batch-light.png and /dev/null differ diff --git a/Docs/a11y-screenshots/classic-dashboard-axxxl.png b/Docs/a11y-screenshots/classic-dashboard-axxxl.png deleted file mode 100644 index a444076..0000000 Binary files a/Docs/a11y-screenshots/classic-dashboard-axxxl.png and /dev/null differ diff --git a/Docs/a11y-screenshots/classic-dashboard-dark.png b/Docs/a11y-screenshots/classic-dashboard-dark.png deleted file mode 100644 index bce2fa1..0000000 Binary files a/Docs/a11y-screenshots/classic-dashboard-dark.png and /dev/null differ diff --git a/Docs/a11y-screenshots/classic-dashboard-light.png b/Docs/a11y-screenshots/classic-dashboard-light.png deleted file mode 100644 index 2afe947..0000000 Binary files a/Docs/a11y-screenshots/classic-dashboard-light.png and /dev/null differ diff --git a/Docs/a11y-screenshots/classic-watchlist-axxxl.png b/Docs/a11y-screenshots/classic-watchlist-axxxl.png deleted file mode 100644 index 42b84cf..0000000 Binary files a/Docs/a11y-screenshots/classic-watchlist-axxxl.png and /dev/null differ diff --git a/Docs/a11y-screenshots/lg-batch-axxxl.png b/Docs/a11y-screenshots/lg-batch-axxxl.png deleted file mode 100644 index db5cb09..0000000 Binary files a/Docs/a11y-screenshots/lg-batch-axxxl.png and /dev/null differ diff --git a/Docs/a11y-screenshots/lg-batch-dark.png b/Docs/a11y-screenshots/lg-batch-dark.png deleted file mode 100644 index c70a7bd..0000000 Binary files a/Docs/a11y-screenshots/lg-batch-dark.png and /dev/null differ diff --git a/Docs/a11y-screenshots/lg-batch-light.png b/Docs/a11y-screenshots/lg-batch-light.png deleted file mode 100644 index cd6c30d..0000000 Binary files a/Docs/a11y-screenshots/lg-batch-light.png and /dev/null differ diff --git a/Docs/a11y-screenshots/lg-dashboard-axxxl.png b/Docs/a11y-screenshots/lg-dashboard-axxxl.png deleted file mode 100644 index 005596c..0000000 Binary files a/Docs/a11y-screenshots/lg-dashboard-axxxl.png and /dev/null differ diff --git a/Docs/a11y-screenshots/lg-dashboard-dark.png b/Docs/a11y-screenshots/lg-dashboard-dark.png deleted file mode 100644 index f181d42..0000000 Binary files a/Docs/a11y-screenshots/lg-dashboard-dark.png and /dev/null differ diff --git a/Docs/a11y-screenshots/lg-dashboard-light-differentiate.png b/Docs/a11y-screenshots/lg-dashboard-light-differentiate.png deleted file mode 100644 index 53bb4c7..0000000 Binary files a/Docs/a11y-screenshots/lg-dashboard-light-differentiate.png and /dev/null differ diff --git a/Docs/a11y-screenshots/lg-dashboard-light.png b/Docs/a11y-screenshots/lg-dashboard-light.png deleted file mode 100644 index d8ca3c8..0000000 Binary files a/Docs/a11y-screenshots/lg-dashboard-light.png and /dev/null differ diff --git a/Docs/a11y-screenshots/lg-watchlist-axxxl.png b/Docs/a11y-screenshots/lg-watchlist-axxxl.png deleted file mode 100644 index c4b8509..0000000 Binary files a/Docs/a11y-screenshots/lg-watchlist-axxxl.png and /dev/null differ diff --git a/SECURITY.md b/SECURITY.md index 1423145..8ce229c 100644 --- a/SECURITY.md +++ b/SECURITY.md @@ -4,8 +4,8 @@ |Version|Supported| |-------|---------| -| 1.x | ✅ Yes | -| < 1.0 | ❌ No | +| 4.x | ✅ Yes | +| < 4.0 | ❌ No | --- @@ -14,7 +14,7 @@ If you discover a security vulnerability, **do not open a public issue**. Instead: -1. **Email** your report to [security@cleberg.net](mailto:security@cleberg.net). +1. **Email** your report to [security@zerolabs.sh](mailto:security@zerolabs.sh). Include: - A detailed description of the vulnerability - Steps to reproduce -- cgit v1.2.3