From c220e26bb496e455a5bdb6a8dc22abf09ecfed5f Mon Sep 17 00:00:00 2001 From: Christian Cleberg Date: Tue, 21 Jul 2026 20:47:34 -0500 Subject: feat(a11y): color independence, reduce motion, reduce transparency (#21 phase 5) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Audit unchanged at 11 dark / 14 light — expected, as none of these settings are exercised by performAccessibilityAudit, and simctl can toggle only Increase Contrast, not Differentiate Without Color, Reduce Motion, or Reduce Transparency. Correct by construction and build-clean; runtime behaviour is verified in the Phase 6 manual pass. Color independence: - Widget status is now an SF Symbol (checkmark.circle.fill / exclamationmark.triangle.fill / exclamationmark.octagon.fill), the same vocabulary as the in-app badges, replacing a silent colour-only dot on both the domain rows and the small-view count pills. Status now survives greyscale and reads consistently across surfaces. - Under accessibilityDifferentiateWithoutColor: the Dashboard summary-card dot becomes a per-filter symbol, the selected quick-filter chip gains a checkmark and a border (selection was fill-colour only, and also gains the .isSelected trait), and LabeledValueRow prefixes a warning/failure symbol. All gated on the setting so the default UI stays uncluttered. Reduce motion: all five withAnimation/.animation sites now pass nil under accessibilityReduceMotion — AppCopyButton's check cross-fade, CollapsibleSectionView's expand/collapse, TimelineDiffView's scroll, and WatchlistView's list reorder. Reduce transparency: the single .thinMaterial capsule falls back to an opaque AppSurfaceElevated fill under accessibilityReduceTransparency. The SweepActivityController item from the plan is dropped: it is pure ActivityKit lifecycle with no animation, confirmed back in the issue triage. --- DomainDig/DashboardView.swift | 61 +++++++++++++++++++++++++++++++++++-------- 1 file changed, 50 insertions(+), 11 deletions(-) (limited to 'DomainDig/DashboardView.swift') diff --git a/DomainDig/DashboardView.swift b/DomainDig/DashboardView.swift index 24955bb..d86e591 100644 --- a/DomainDig/DashboardView.swift +++ b/DomainDig/DashboardView.swift @@ -2,6 +2,7 @@ import SwiftUI struct DashboardView: View { @Environment(\.appDensity) private var appDensity + @Environment(\.accessibilityDifferentiateWithoutColor) private var differentiateWithoutColor @Bindable var viewModel: DomainViewModel @State private var collapsedGroups = Set() @@ -44,15 +45,33 @@ struct DashboardView: View { Button { viewModel.dashboardFilter = filter } label: { - Text(filter.title) - .font(appDensity.font(.caption, weight: .semibold)) - .foregroundStyle(viewModel.dashboardFilter == filter ? Color(.appOnAccent) : Color.primary) - .padding(.horizontal, 12) - .padding(.vertical, 8) - .background(viewModel.dashboardFilter == filter ? Color(.statusInfo) : Color(.appSurfaceElevated)) - .clipShape(Capsule()) + let isSelected = viewModel.dashboardFilter == filter + HStack(spacing: 4) { + // Selection is a fill-colour change; under + // Differentiate Without Color add a + // checkmark + border so it does not depend + // on hue alone. + if isSelected, differentiateWithoutColor { + Image(systemName: "checkmark") + .font(.caption2.weight(.bold)) + } + Text(filter.title) + .font(appDensity.font(.caption, weight: .semibold)) + } + .foregroundStyle(isSelected ? Color(.appOnAccent) : Color.primary) + .padding(.horizontal, 12) + .padding(.vertical, 8) + .background(isSelected ? Color(.statusInfo) : Color(.appSurfaceElevated)) + .overlay( + Capsule().strokeBorder( + Color.primary, + lineWidth: isSelected && differentiateWithoutColor ? 1.5 : 0 + ) + ) + .clipShape(Capsule()) } .buttonStyle(.plain) + .accessibilityAddTraits(viewModel.dashboardFilter == filter ? .isSelected : []) } } .padding(.vertical, 4) @@ -198,10 +217,18 @@ struct DashboardView: View { // Was a fixed 28pt, which ignored Dynamic Type entirely. .font(.system(.title, design: .rounded, weight: .bold)) .foregroundStyle(.primary) - HStack { - Circle() - .fill(tint) - .frame(width: 8, height: 8) + HStack(spacing: 5) { + // A symbol under Differentiate Without Color (where a bare + // colour dot conveys nothing), a plain dot otherwise. + if differentiateWithoutColor { + Image(systemName: symbol(for: filter)) + .font(.caption2) + .foregroundStyle(tint) + } else { + Circle() + .fill(tint) + .frame(width: 8, height: 8) + } Text(filter.title) .font(appDensity.font(.caption2, design: .default, weight: .semibold)) .foregroundStyle(tint) @@ -215,6 +242,18 @@ struct DashboardView: View { .buttonStyle(.plain) } + private func symbol(for filter: PortfolioFilterOption) -> String { + switch filter { + case .all: return "square.grid.2x2.fill" + case .healthy: return "checkmark.circle.fill" + case .warning: return "exclamationmark.triangle.fill" + case .critical: return "exclamationmark.octagon.fill" + case .changed: return "arrow.triangle.2.circlepath" + case .expiring: return "clock.badge.exclamationmark.fill" + case .unreachable: return "wifi.slash" + } + } + private func cardBackground(for filter: PortfolioFilterOption) -> some ShapeStyle { if viewModel.dashboardFilter == filter { // Uses the authored info surface rather than a translucent wash of -- cgit v1.2.3