From 0b84ecaf7ba0fb2cd3f3867da8dc732450b55b50 Mon Sep 17 00:00:00 2001
From: Christian Cleberg <hello@cleberg.net>
Date: Mon, 13 Apr 2026 13:35:03 -0500
Subject: perf: cache filtered collections and add equatable row views
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Convert filteredJobs, filteredPastes, and filteredTickets from computed
properties to stored properties updated via didSet on their inputs. Each
update function guards with an equality check before assigning, so
@Observable skips the notification when the filtered result hasn't
changed — preventing list re-renders on auto-refresh when no visible
data has actually changed.

Add Equatable conformance to BuildRowView, PasteRowView, TicketRowView,
and SelectableTicketRow, and apply .equatable() at each ForEach call
site. When a list does re-render, SwiftUI now skips body evaluation for
rows whose model value is identical to the previous pass.

Implements: https://todo.sr.ht/~ccleberg/hutch/57
---
 Hutch/Views/Pastes/PasteListViewModel.swift | 28 ++++++++++++++++++++--------
 1 file changed, 20 insertions(+), 8 deletions(-)

(limited to 'Hutch/Views/Pastes/PasteListViewModel.swift')

diff --git a/Hutch/Views/Pastes/PasteListViewModel.swift b/Hutch/Views/Pastes/PasteListViewModel.swift
index b521e18..75f2f4b 100644
--- a/Hutch/Views/Pastes/PasteListViewModel.swift
+++ b/Hutch/Views/Pastes/PasteListViewModel.swift
@@ -3,13 +3,18 @@ import Foundation
 @Observable
 @MainActor
 final class PasteListViewModel {
-    private(set) var pastes: [Paste] = []
+    private(set) var pastes: [Paste] = [] {
+        didSet { updateFilteredPastes() }
+    }
     private(set) var isLoading = false
     private(set) var isLoadingMore = false
     private(set) var isRefreshing = false
     private(set) var isCreatingPaste = false
     var error: String?
-    var searchText = ""
+    var searchText = "" {
+        didSet { updateFilteredPastes() }
+    }
+    private(set) var filteredPastes: [Paste] = []
 
     private var cursor: String?
     private var hasMore = true
@@ -19,15 +24,22 @@ final class PasteListViewModel {
         self.service = service
     }
 
-    var filteredPastes: [Paste] {
+    private func updateFilteredPastes() {
         let q = searchText.trimmingCharacters(in: .whitespacesAndNewlines).lowercased()
-        guard !q.isEmpty else { return pastes }
-        return pastes.filter {
-            $0.files.contains {
-                ($0.filename?.lowercased().contains(q) == true) ||
-                $0.hash.lowercased().hasPrefix(q)
+        let updated: [Paste]
+        if q.isEmpty {
+            updated = pastes
+        } else {
+            updated = pastes.filter {
+                $0.files.contains {
+                    ($0.filename?.lowercased().contains(q) == true) ||
+                    $0.hash.lowercased().hasPrefix(q)
+                }
             }
         }
+        if updated != filteredPastes {
+            filteredPastes = updated
+        }
     }
 
     func loadPastes() async {
-- 
cgit v1.2.3