From 575e62f6dab44b0c9836623fe8b7d17a219f8e0f Mon Sep 17 00:00:00 2001 From: Christian Cleberg Date: Wed, 15 Jul 2026 21:56:56 -0500 Subject: fix: push patchset views directly instead of by route Tapping a patch failed with "no matching navigationDestination declaration visible from the location of the link". MailingListDetailView is presented from four places, but only the More tab and Lookup declare a MoreRoute destination. Reached from a project, via ProjectMailingListView, there is no such destination in the surrounding stack, so a NavigationLink carrying MoreRoute.patchset had nowhere to resolve. The thread rows beside it already use the closure form for exactly this reason. Push PatchsetDetailView directly, from the rows and from the version-chain links inside the detail view, which inherits whatever stack presented it. That leaves MoreRoute.patchset with no users, so it and its two destinations are removed rather than left as a route nothing links to. Neither the compiler nor the tests catch this: it is a runtime SwiftUI resolution failure. --- Hutch/Views/Patchsets/PatchsetDetailView.swift | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) (limited to 'Hutch/Views/Patchsets/PatchsetDetailView.swift') diff --git a/Hutch/Views/Patchsets/PatchsetDetailView.swift b/Hutch/Views/Patchsets/PatchsetDetailView.swift index d76aab4..7bc5630 100644 --- a/Hutch/Views/Patchsets/PatchsetDetailView.swift +++ b/Hutch/Views/Patchsets/PatchsetDetailView.swift @@ -122,8 +122,14 @@ struct PatchsetDetailView: View { // The version chain matters during review: a superseded series should // usually be read at its newest version instead. + // + // Pushed directly rather than by value, for the same reason as the rows + // that lead here — this view inherits whatever stack presented it, and + // not all of them declare a MoreRoute destination. if let supersededBy = patchset.supersededBy { - NavigationLink(value: MoreRoute.patchset(id: supersededBy, listName: listName)) { + NavigationLink { + PatchsetDetailView(patchsetID: supersededBy, listName: listName) + } label: { SwiftUI.Label("Superseded by a newer version", systemImage: "arrow.right.circle") .font(.subheadline) } @@ -131,7 +137,9 @@ struct PatchsetDetailView: View { } if let supersedes = patchset.supersedes { - NavigationLink(value: MoreRoute.patchset(id: supersedes, listName: listName)) { + NavigationLink { + PatchsetDetailView(patchsetID: supersedes, listName: listName) + } label: { SwiftUI.Label("Revises an earlier version", systemImage: "arrow.left.circle") .font(.subheadline) } -- cgit v1.2.3