From 236a22553d5cb9e07b3115c03864c882e0c41b77 Mon Sep 17 00:00:00 2001 From: Christian Cleberg Date: Fri, 3 Apr 2026 15:47:34 -0500 Subject: chore: add explanatory comments to all intentional empty closures --- Hutch/Views/Tickets/TicketListView.swift | 8 +++++--- Hutch/Views/Tickets/TrackerListView.swift | 4 +++- Hutch/Views/Tickets/TrackerManagementView.swift | 8 ++++++-- 3 files changed, 14 insertions(+), 6 deletions(-) (limited to 'Hutch/Views/Tickets') diff --git a/Hutch/Views/Tickets/TicketListView.swift b/Hutch/Views/Tickets/TicketListView.swift index 4a48377..21e806c 100644 --- a/Hutch/Views/Tickets/TicketListView.swift +++ b/Hutch/Views/Tickets/TicketListView.swift @@ -25,8 +25,8 @@ struct TicketListView: View { init( tracker: TrackerSummary, - onTrackerUpdated: @escaping (TrackerSummary) -> Void = { _ in }, - onTrackerDeleted: @escaping (TrackerSummary) -> Void = { _ in } + onTrackerUpdated: @escaping (TrackerSummary) -> Void = { _ in /* no-op: default for callers that don't handle this event */ }, + onTrackerDeleted: @escaping (TrackerSummary) -> Void = { _ in /* no-op: default for callers that don't handle this event */ } ) { self._tracker = State(initialValue: tracker) self.onTrackerUpdated = onTrackerUpdated @@ -123,7 +123,9 @@ struct TicketListView: View { } } .alert("Delete Tracker?", isPresented: $showDeleteTrackerConfirmation) { - Button("Cancel", role: .cancel) {} + Button("Cancel", role: .cancel) { + // no-op: .cancel role handles alert dismissal + } Button("Delete", role: .destructive) { guard let trackerManagementViewModel else { return } Task { diff --git a/Hutch/Views/Tickets/TrackerListView.swift b/Hutch/Views/Tickets/TrackerListView.swift index ac539df..50604b8 100644 --- a/Hutch/Views/Tickets/TrackerListView.swift +++ b/Hutch/Views/Tickets/TrackerListView.swift @@ -106,7 +106,9 @@ struct TrackerListView: View { } } )) { - Button("Cancel", role: .cancel) {} + Button("Cancel", role: .cancel) { + // no-op: .cancel role handles alert dismissal + } Button("Delete", role: .destructive) { guard let pendingDeletion, let viewModel else { return } Task { diff --git a/Hutch/Views/Tickets/TrackerManagementView.swift b/Hutch/Views/Tickets/TrackerManagementView.swift index 5c08e4a..1542d54 100644 --- a/Hutch/Views/Tickets/TrackerManagementView.swift +++ b/Hutch/Views/Tickets/TrackerManagementView.swift @@ -820,7 +820,9 @@ struct TrackerACLManagementSheet: View { } } )) { - Button("Cancel", role: .cancel) {} + Button("Cancel", role: .cancel) { + // no-op: .cancel role handles alert dismissal + } Button("Delete", role: .destructive) { guard let pendingDeletion else { return } Task { @@ -1157,7 +1159,9 @@ struct TrackerLabelManagementSheet: View { } } )) { - Button("Cancel", role: .cancel) {} + Button("Cancel", role: .cancel) { + // no-op: .cancel role handles alert dismissal + } Button("Delete", role: .destructive) { guard let pendingDeletion else { return } Task { -- cgit v1.2.3