skunky-art.git, branch v1.3.3

fix: document exported API, fix naming, and harden Download

2026-07-15T07:25:20+00:00

The remaining golangci-lint findings. These land together because the Url -> URL rename spans util.go, parsers.go and wrapper.go, and splitting it would leave an intermediate commit that does not compile. Download() carried the most serious bug here: try() only prints an error, it does not return, so a failed request fell through to resp.Body.Close() on a nil resp and panicked. Every failure path now returns the zero Downloaded, and callers check Status. ReturnHTTPError guards against the resulting status 0, which would otherwise panic WriteHeader. Requests carry a context with a timeout (noctx), and a download-proxy now routes through ProxiedTransport so it keeps the DA throttle and timeouts. Also: - doc comments on all 48 exported symbols (revive's exported rule, with checkPrivateReceivers, since most of app is exported methods on the unexported skunkyart type), plus package docs in new doc.go files so both the embed and non-embed builds are covered. - ST1003 naming: UrlBuilder -> URLBuilder, id_search -> idSearch, cache_config -> cacheConfig, TXT_RAW -> TxtRaw, mediaUrl -> mediaURL. - explicit json tags on structs that are unmarshaled (musttag); the hyphenated keys already had tags, the rest relied on case-insensitive fallback. Behaviour is unchanged. - modernization: range-over-int, WaitGroup.Go, stale +build lines, interface{} -> any, strings.Builder over string concatenation in a loop.

fix: harden HTTP transport, server timeouts and panic paths

2026-07-15T07:24:58+00:00

Correctness and security findings surfaced by golangci-lint, plus two latent panics found alongside them. - router: http.ListenAndServe has no timeouts at all (gosec G114), so a slow client could hold a connection and its handler open indefinitely. Replace it with an explicit http.Server carrying read/write/idle timeouts. - httpclient: InstallDAThrottle asserted http.DefaultTransport was a *http.Transport and would panic outright if anything had already wrapped it -- which is precisely what that function does. Check the assertion and fall back to a fresh transport. Expose ProxiedTransport so a configured download-proxy can inherit the same throttle and timeouts instead of silently bypassing them. - cache: the Sys() assertion to *syscall.Stat_t is only valid on unix and would panic elsewhere; skip rotation instead. Indexing Headers["Content-Type"][0] panics when the header is absent; use Headers.Get. Cache files are written 0600 rather than 0700, as they are never executed. - cli, api: check error returns, and exit rather than nil-dereference a file handle that failed to open. SHA-1 and math/rand keep //nolint:gosec with reasons: they are cache-key hashes and random-artwork picks, not security primitives.

fix(cache): correct max-size megabyte conversion

2026-07-15T07:23:59+00:00

max-size is documented in SETUP.md as megabytes, but the conversion was `*= 1024 ^ 2`. In Go `^` is XOR, not exponentiation, so this multiplied by 1026 rather than 1048576 -- a configured max-size of 200 produced a ~205 KB cap instead of 200 MB, wiping the cache almost immediately. This changes runtime behaviour: the cache will now grow to the size the config actually asks for.

build: add golangci-lint configuration

2026-07-15T07:23:40+00:00

Enables the standard linters plus revive's exported rule, a set of correctness/security linters (bodyclose, noctx, gosec, forcetypeassert, canonicalheader, musttag, predeclared, exhaustive), modernization linters, and staticcheck's full check set including the doc-comment and naming checks that are off by default. The idiom-fighting linters stay off: varnamelen objects to short names that are idiomatic Go, exhaustruct demands every field be initialized, gochecknoglobals flags CFG/Host which are deliberate, and tagliatelle would rename JSON config keys and break existing instances' configs.

fix: remove russian language throughout

2026-07-15T06:58:41+00:00

Bump golang.org/x/net from 0.27.0 to 0.57.0 (#3)

2026-07-15T06:48:14+00:00

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.27.0 to 0.57.0. - [Commits](https://github.com/golang/net/compare/v0.27.0...v0.57.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.57.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix: point source links and instance fetch at this fork

2026-07-15T01:28:02+00:00

Upstream references still pointed at git.macaw.me, which is unmaintained and whose instances.json is a dead link. Repoint them at this repo: - RefreshInstances now fetches instances.json from raw.githubusercontent - source/version links in index.htm, about.htm, and CLI help use the GitHub releases tag URL - SETUP.md/SETUP-RU.md language switch links were Gitea-absolute paths that 404 on GitHub; make them relative - --add-instance message says 'main' branch, matching this repo The fork attribution in README.md is left as-is: it credits upstream rather than pointing at the source.

Merge dev: devianter v0.3.1 migration, DA throttle, fixes

2026-07-15T01:23:47+00:00

Migrate to github.com/zerolabsco/devianter v0.3.1 and adapt to its reordered return values, throttle outbound DeviantArt requests, harden the random-art retry loop, and fix the darwin build.

docs: add optional VPN egress compose example

2026-07-15T01:22:33+00:00

CloudFront/WAF blocks some egress IPs on the /_puppy path, making every DA-backed page fail while Go tries to unmarshal an HTML 403 page. Routing outbound through a non-blocked exit fixes it with no code change, since devianter's client honors HTTPS_PROXY. Adds a compose stack with an optional gluetun sidecar behind the "vpn" profile (off by default, so the stock direct setup is unchanged) and a matching .env.example. Ignore .env so real credentials stay out of git.

feat: throttle and time out outbound DeviantArt requests

2026-07-15T01:22:26+00:00

DeviantArt fronts its API with CloudFront + WAF, which bans egress IPs that hit it too hard. devianter issues requests with a bare http.Client, so unbounded concurrent handlers each pulled ~150-200 KB of JSON, which both risked a ban and could exhaust the process under a bot flood. Wrap the default transport to bound rate and concurrency for deviantart.com and add timeouts. Other hosts (wixmp image CDN) pass straight through, so media stays fast, and ProxyFromEnvironment is preserved so HTTPS_PROXY egress still works.