diff options
| author | Christian Cleberg <[email protected]> | 2026-07-20 18:16:01 -0500 |
|---|---|---|
| committer | Christian Cleberg <[email protected]> | 2026-07-20 18:50:57 -0500 |
| commit | eb8a0d30da0cc150e95d44bad998c13ee2defc25 (patch) | |
| tree | 1ad349e302b5b48bbc9f79d17a66bcfc31dace11 /DomainDigUITests/AccessibilityAuditTests.swift | |
| parent | 1e25fb947d3c01fc983b481fff5b064ed82349ab (diff) | |
| download | domain-dig-eb8a0d30da0cc150e95d44bad998c13ee2defc25.tar.gz domain-dig-eb8a0d30da0cc150e95d44bad998c13ee2defc25.tar.bz2 domain-dig-eb8a0d30da0cc150e95d44bad998c13ee2defc25.zip | |
feat(a11y): semantic colour system (#21 phase 1)
Replaces every hard-coded colour with semantic asset colours that adapt to
light, dark, and Increase Contrast. Dark mode stays locked, so this is a
pure refactor: the audit reports the same findings before and after.
The accent is now blue rather than cyan, per the tech/DNS theme.
Why custom values rather than the system palette: every system colour
fails WCAG AA in light mode. Measured on white — systemYellow 1.51:1,
systemOrange 2.20:1, systemGreen 2.22:1, systemCyan 2.54:1, systemRed
3.55:1. All of them pass in dark mode, which is why the dark-locked app
looked fine, and why unlocking light mode was never a matter of deleting
.preferredColorScheme(.dark). Every new value clears 4.5:1 as text on its
page, its card, and its own 16% badge tint — the way AppStatusBadgeView
actually draws it.
The accent needed splitting in two. As text on a dark background it must
be light; as a fill behind a white label it must be dark. #4DA3FF reads
8.00:1 as text on black but 2.63:1 behind white text, so StatusInfo /
AccentColor cover the foreground role and AccentFill covers
.borderedProminent. AppOnAccent is the label colour for a solid fill and
flips by scheme.
Colours live in Shared/Colors.xcassets rather than the app catalog: the
Shared folder is already a synchronized group in all three targets, so
the widget and share extension pick the palette up with no project-file
surgery. AccentColor stays in the app catalog as the global tint — and is
now actually defined, having been an empty colorset that silently left
system controls rendering in stock blue while custom chrome used cyan.
Two deliberate visual changes: orange folds into StatusWarning and pink
into StatusCritical. They encoded the same severity as the colours they
now share, and both sites also carry a text label.
Audit findings drop 15 to 14, and one of the originals turned out to be
a phantom: the Inspect contrast failure was the Run button in its
disabled state, which WCAG 1.4.3 exempts. testInspectScreen now types a
domain first so the audit measures an enabled control. Findings also
carry the offending element now, so the remaining clipped-text items name
themselves ("No Portfolio Yet", "Search domains") instead of being
anonymous.
Diffstat (limited to 'DomainDigUITests/AccessibilityAuditTests.swift')
| -rw-r--r-- | DomainDigUITests/AccessibilityAuditTests.swift | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/DomainDigUITests/AccessibilityAuditTests.swift b/DomainDigUITests/AccessibilityAuditTests.swift index 6a90bac..63ae584 100644 --- a/DomainDigUITests/AccessibilityAuditTests.swift +++ b/DomainDigUITests/AccessibilityAuditTests.swift @@ -17,7 +17,20 @@ final class AccessibilityAuditTests: XCTestCase { // MARK: Per-screen audits func testInspectScreen() throws { - try auditRootTab("Inspect") + let app = AccessibilityAuditHarness.launch() + app.selectRootTab("Inspect") + + // Type a domain so the Run button is enabled. A disabled control has no + // contrast requirement under WCAG 1.4.3, but the audit still flags it, + // so auditing the empty state would report a false positive forever. + let field = app.textFields.firstMatch + if field.waitForExistence(timeout: 5) { + field.tap() + field.typeText("example.com") + } + + let audited = try AccessibilityAuditHarness.audit(app, screen: "inspect", test: self) + try XCTSkipUnless(audited, "Audit did not complete in time for Inspect") } func testDashboardScreen() throws { |
