diff options
| author | Christian Cleberg <[email protected]> | 2026-07-15 21:56:56 -0500 |
|---|---|---|
| committer | Christian Cleberg <[email protected]> | 2026-07-15 21:56:56 -0500 |
| commit | 575e62f6dab44b0c9836623fe8b7d17a219f8e0f (patch) | |
| tree | ef1740b6841259193e01e868da1dd1df683ae844 /Hutch/App/RootView.swift | |
| parent | 22c7a0e45a5cc344e2fa0635431d95c23024ad63 (diff) | |
| download | hutch-575e62f6dab44b0c9836623fe8b7d17a219f8e0f.tar.gz hutch-575e62f6dab44b0c9836623fe8b7d17a219f8e0f.tar.bz2 hutch-575e62f6dab44b0c9836623fe8b7d17a219f8e0f.zip | |
fix: push patchset views directly instead of by route
Tapping a patch failed with "no matching navigationDestination declaration
visible from the location of the link".
MailingListDetailView is presented from four places, but only the More tab and
Lookup declare a MoreRoute destination. Reached from a project, via
ProjectMailingListView, there is no such destination in the surrounding stack,
so a NavigationLink carrying MoreRoute.patchset had nowhere to resolve. The
thread rows beside it already use the closure form for exactly this reason.
Push PatchsetDetailView directly, from the rows and from the version-chain
links inside the detail view, which inherits whatever stack presented it. That
leaves MoreRoute.patchset with no users, so it and its two destinations are
removed rather than left as a route nothing links to.
Neither the compiler nor the tests catch this: it is a runtime SwiftUI
resolution failure.
Diffstat (limited to 'Hutch/App/RootView.swift')
| -rw-r--r-- | Hutch/App/RootView.swift | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/Hutch/App/RootView.swift b/Hutch/App/RootView.swift index 59d7caa..1ae4651 100644 --- a/Hutch/App/RootView.swift +++ b/Hutch/App/RootView.swift @@ -439,7 +439,6 @@ enum MoreRoute: Hashable { case projectDashboard(id: String, title: String?) case mailingList(InboxMailingListReference) case thread(InboxThreadSummary) - case patchset(id: Int, listName: String?) case manPageBrowser case manPage(URL) } @@ -473,8 +472,6 @@ private struct MoreNavigationRoot: View { ProjectDashboardDeepLinkView(projectID: id, title: title) case .mailingList(let mailingList): MailingListDetailView(mailingList: mailingList) - case .patchset(let id, let listName): - PatchsetDetailView(patchsetID: id, listName: listName) case .thread(let thread): ThreadDetailView( thread: thread, |
