diff options
| author | Christian Cleberg <[email protected]> | 2026-07-16 10:18:40 -0500 |
|---|---|---|
| committer | Christian Cleberg <[email protected]> | 2026-07-16 10:18:40 -0500 |
| commit | e93972f39150e5e590e49aaf46a369c463277c30 (patch) | |
| tree | 2eb72968c1101155db1ee97e74367eb6491cd86b /Hutch/Views/Tickets/TicketDetailView.swift | |
| parent | 9834b780b24a1dd617fa761155712920159f3d8d (diff) | |
| download | hutch-e93972f39150e5e590e49aaf46a369c463277c30.tar.gz hutch-e93972f39150e5e590e49aaf46a369c463277c30.tar.bz2 hutch-e93972f39150e5e590e49aaf46a369c463277c30.zip | |
chore: clear the actionable SonarCloud code smells
- S1871: merge the identical .home / .recentActivity deep-link cases in
RootView — recent activity is a section of Home, not its own screen.
- S1186: comment the two intentionally-empty Cancel buttons
(PatchsetDetailView, TicketDetailView) and the empty URLProtocol
stopLoading override in APICacheTests.
- S108: comment the expected-miss catch block in APICacheTests.
- S1172: rename the unused url parameter in mimeType(for:) to _.
- S4624: extract the nested template literal in the deep-link builders
(background.js, content.js) to a pathSegment variable.
Left as Won't Fix, with reasons: the 35 hardcoded-URI warnings (a
one-forge client and its literal-URL tests), executeCached's 8 params
(38 call sites, no benefit), the forceRefresh S1172 pair (fixed as a
real bug instead), S1481 on ArtifactsView (false positive — $vm.error
is used), and S7785 (top-level await would break a classic content
script).
Diffstat (limited to 'Hutch/Views/Tickets/TicketDetailView.swift')
| -rw-r--r-- | Hutch/Views/Tickets/TicketDetailView.swift | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Hutch/Views/Tickets/TicketDetailView.swift b/Hutch/Views/Tickets/TicketDetailView.swift index b114fa6..1705a73 100644 --- a/Hutch/Views/Tickets/TicketDetailView.swift +++ b/Hutch/Views/Tickets/TicketDetailView.swift @@ -204,7 +204,7 @@ struct TicketDetailView: View { } } } - Button("Cancel", role: .cancel) {} + Button("Cancel", role: .cancel) {} // dismisses the dialog; no action needed } message: { Text("This permanently deletes the ticket and its comments. This cannot be undone.") } |
