summaryrefslogtreecommitdiff
path: root/Hutch/Views/Tickets/TicketListView.swift
diff options
context:
space:
mode:
authorChristian Cleberg <[email protected]>2026-04-13 13:35:03 -0500
committerChristian Cleberg <[email protected]>2026-04-13 13:35:03 -0500
commit0b84ecaf7ba0fb2cd3f3867da8dc732450b55b50 (patch)
treec2d92448661d9e6ca76bd7c69e9d51131305214e /Hutch/Views/Tickets/TicketListView.swift
parent06b24715cd244475ded5482e926721a57278a3cf (diff)
downloadhutch-0b84ecaf7ba0fb2cd3f3867da8dc732450b55b50.tar.gz
hutch-0b84ecaf7ba0fb2cd3f3867da8dc732450b55b50.tar.bz2
hutch-0b84ecaf7ba0fb2cd3f3867da8dc732450b55b50.zip
perf: cache filtered collections and add equatable row views
Convert filteredJobs, filteredPastes, and filteredTickets from computed properties to stored properties updated via didSet on their inputs. Each update function guards with an equality check before assigning, so @Observable skips the notification when the filtered result hasn't changed — preventing list re-renders on auto-refresh when no visible data has actually changed. Add Equatable conformance to BuildRowView, PasteRowView, TicketRowView, and SelectableTicketRow, and apply .equatable() at each ForEach call site. When a list does re-render, SwiftUI now skips body evaluation for rows whose model value is identical to the previous pass. Implements: https://todo.sr.ht/~ccleberg/hutch/57
Diffstat (limited to 'Hutch/Views/Tickets/TicketListView.swift')
-rw-r--r--Hutch/Views/Tickets/TicketListView.swift6
1 files changed, 4 insertions, 2 deletions
diff --git a/Hutch/Views/Tickets/TicketListView.swift b/Hutch/Views/Tickets/TicketListView.swift
index 8f7d348..e58d194 100644
--- a/Hutch/Views/Tickets/TicketListView.swift
+++ b/Hutch/Views/Tickets/TicketListView.swift
@@ -290,6 +290,7 @@ struct TicketListView: View {
ticket: ticket,
isSelected: viewModel.selectedTicketIDs.contains(ticket.id)
)
+ .equatable()
}
.buttonStyle(.plain)
} else {
@@ -303,6 +304,7 @@ struct TicketListView: View {
)
} label: {
TicketRowView(ticket: ticket)
+ .equatable()
}
.contextMenu {
if let url = SRHTWebURL.ticket(ownerUsername: ownerUsername(for: tracker), trackerName: tracker.name, ticketId: ticket.id) {
@@ -1180,7 +1182,7 @@ private struct BulkAssignSheet: View {
}
}
-private struct SelectableTicketRow: View {
+private struct SelectableTicketRow: View, Equatable {
let ticket: TicketSummary
let isSelected: Bool
@@ -1200,7 +1202,7 @@ private struct SelectableTicketRow: View {
// MARK: - Ticket Row
-private struct TicketRowView: View {
+private struct TicketRowView: View, Equatable {
let ticket: TicketSummary
var body: some View {