summaryrefslogtreecommitdiff
path: root/ROADMAP.md
diff options
context:
space:
mode:
authorChristian Cleberg <[email protected]>2026-07-15 22:41:33 -0500
committerGitHub <[email protected]>2026-07-15 22:41:33 -0500
commit922502a2c74c66034f3ec2db6612f2a36d242042 (patch)
tree0867730c955e308437b8c86dd37638c9bff6c9c5 /ROADMAP.md
parentb9ec80716ea015de5b6b31395fdc5ff03191398c (diff)
parent1d2769fc7a347939275e9130ee174d61d96ea401 (diff)
downloadhutch-922502a2c74c66034f3ec2db6612f2a36d242042.tar.gz
hutch-922502a2c74c66034f3ec2db6612f2a36d242042.tar.bz2
hutch-922502a2c74c66034f3ec2db6612f2a36d242042.zip
Merge pull request #4 from zerolabsco/phase-2-patchsets
Phase 2: patchset review
Diffstat (limited to 'ROADMAP.md')
-rw-r--r--ROADMAP.md37
1 files changed, 23 insertions, 14 deletions
diff --git a/ROADMAP.md b/ROADMAP.md
index e86ddb0..66e56cf 100644
--- a/ROADMAP.md
+++ b/ROADMAP.md
@@ -74,24 +74,33 @@ Known follow-up: `BuildListViewModel`, `RepositoryListViewModel`, and
two different cache keys. That predates `APICacheKeys` and should be folded into
`cachedPayload`.
-## Phase 2: Patchsets
+## Phase 2: Patchsets — done (v3.7.0)
-The flagship gap. There is currently no reference to `patchset` anywhere in the
-Swift source, yet lists.sr.ht exposes a full `Patchset` type (subject, version,
-prefix, status, coverLetter, patches, tools, mbox), a `patchset` query, and an
-`updatePatchset` mutation. Sending and reviewing patches over email is the
-SourceHut contribution model, and Hutch cannot currently participate in it.
+The flagship gap. Sending and reviewing patches over email is the SourceHut
+contribution model, and Hutch had no reference to `patchset` anywhere.
-Scope this as review-and-triage, not submission:
+Scoped as review-and-triage, not submission:
-- Patchset list per mailing list.
-- Patchset detail: cover letter, per-patch diffs (reuse the existing
- `DiffView`), version and superseded-by chain.
-- Status transitions via `updatePatchset`.
+- ~~Patchset list per mailing list~~ — see the caveat below.
+- ~~Patchset detail~~: cover letter, per-patch diffs (via the existing
+ `DiffView`), checks, and the version / superseded-by chain.
+- ~~Status transitions via `updatePatchset`~~.
-Patch *submission* is an email / `git send-email` flow and is likely out of
-reach from the app. Treat that boundary as explicit rather than half-building
-it.
+Two schema facts shaped the result, and are worth knowing before extending this:
+
+- **`MailingList` has no `patchsets` field.** A list's patchsets cannot be
+ queried directly; they are reachable only through thread roots. The existing
+ threads query now also selects `root.patchset`, so the Patches tab costs no
+ extra request — but it also means patchsets cannot be filtered by status
+ server-side, and only patchsets whose thread appears in the current page are
+ listed.
+- **`Patch` carries no diff.** It has only `index`, `count`, `version`,
+ `prefix`, `subject`, and `trailers`. The diff exists solely inside the email
+ body, so it is recovered with `InboxThreadUtilities.segmentMessageBody` — the
+ same splitter the inbox thread view uses.
+
+Patch *submission* remains out of reach: it is a `git send-email` flow, not a
+GraphQL mutation. Treat that boundary as explicit rather than half-building it.
## Phase 3: Polish and reach