1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
|
import Foundation
import Testing
@testable import Hutch
struct RepositoryACLViewModelTests {
@Test
@MainActor
func addValidationRejectsOwnerAndDuplicates() async {
let service = MockRepositoryACLService()
service.fetchResponses = [[
RepositoryACLEntry(
id: 2,
mode: .ro,
entity: Entity(canonicalName: "~alice")
)
]]
let viewModel = RepositoryACLViewModel(repository: makeRepository(), service: service)
viewModel.addUsername = "~owner"
#expect(viewModel.addValidationMessage == "The repository owner already has access.")
await viewModel.load()
viewModel.addUsername = "alice"
#expect(viewModel.addValidationMessage == "That user already has access.")
}
@Test
@MainActor
func addEntryRefreshesListAfterSuccess() async {
let service = MockRepositoryACLService()
service.fetchResponses = [[
RepositoryACLEntry(
id: 2,
mode: .rw,
entity: Entity(canonicalName: "~alice")
)
]]
let viewModel = RepositoryACLViewModel(repository: makeRepository(), service: service)
viewModel.addUsername = "alice"
viewModel.addMode = .rw
let didAdd = await viewModel.addEntry()
#expect(didAdd)
#expect(service.upsertRequests == [MockRepositoryACLService.UpsertRequest(repositoryId: 1, entity: "~alice", mode: .rw)])
#expect(service.fetchRequestRids == ["rid-1"])
#expect(viewModel.visibleEntries.map(\.entity.canonicalName) == ["~alice"])
#expect(viewModel.addUsername.isEmpty)
}
@Test
@MainActor
func permissionUpdateFailureLeavesExistingEntryUntouched() async {
let service = MockRepositoryACLService()
service.upsertError = SRHTError.httpError(500)
let entry = RepositoryACLEntry(
id: 2,
mode: .ro,
entity: Entity(canonicalName: "~alice")
)
let viewModel = RepositoryACLViewModel(repository: makeRepository(), service: service)
service.fetchResponses = [[entry]]
await viewModel.load()
await viewModel.updatePermission(for: entry, to: .rw)
#expect(viewModel.visibleEntries.first?.mode == .ro)
#expect(viewModel.updatingEntryIDs.isEmpty)
#expect(viewModel.error != nil)
}
@Test
@MainActor
func removeFailureKeepsEntryVisible() async {
let service = MockRepositoryACLService()
service.deleteError = SRHTError.httpError(500)
let entry = RepositoryACLEntry(
id: 2,
mode: .ro,
entity: Entity(canonicalName: "~alice")
)
let viewModel = RepositoryACLViewModel(repository: makeRepository(), service: service)
service.fetchResponses = [[entry]]
await viewModel.load()
await viewModel.removeEntry(entry)
#expect(viewModel.visibleEntries.map(\.id) == [2])
#expect(viewModel.deletingEntryIDs.isEmpty)
#expect(viewModel.error != nil)
}
@Test
@MainActor
func initialLoadFailureSetsBlockingErrorState() async {
let service = MockRepositoryACLService()
service.fetchError = SRHTError.httpError(500)
let viewModel = RepositoryACLViewModel(repository: makeRepository(), service: service)
await viewModel.load()
#expect(viewModel.loadError != nil)
#expect(viewModel.visibleEntries.isEmpty)
}
@MainActor
private func makeRepository() -> RepositorySummary {
RepositorySummary(
fields: .init(
id: 1,
rid: "rid-1",
service: .git,
name: "repo",
description: nil,
visibility: .publicVisibility,
updated: .now,
owner: Entity(canonicalName: "~owner"),
head: nil
)
)
}
}
@MainActor
private final class MockRepositoryACLService: RepositoryACLServicing {
struct UpsertRequest: Equatable {
let repositoryId: Int
let entity: String
let mode: AccessMode
}
var fetchResponses: [[RepositoryACLEntry]] = []
var fetchError: Error?
var upsertResponse = RepositoryACLEntry(
id: 2,
mode: .ro,
entity: Entity(canonicalName: "~alice")
)
var upsertError: Error?
var deleteError: Error?
private(set) var fetchRequestRids: [String] = []
private(set) var upsertRequests: [UpsertRequest] = []
private(set) var deleteRequestIDs: [Int] = []
func fetchACLs(repositoryRid: String) async throws -> [RepositoryACLEntry] {
fetchRequestRids.append(repositoryRid)
if let fetchError {
throw fetchError
}
if !fetchResponses.isEmpty {
return fetchResponses.removeFirst()
}
return []
}
func upsertACL(repositoryId: Int, entity: String, mode: AccessMode) async throws -> RepositoryACLEntry {
upsertRequests.append(UpsertRequest(repositoryId: repositoryId, entity: entity, mode: mode))
if let upsertError {
throw upsertError
}
return RepositoryACLEntry(id: upsertResponse.id, mode: mode, entity: Entity(canonicalName: entity))
}
func deleteACL(entryId: Int) async throws {
deleteRequestIDs.append(entryId)
if let deleteError {
throw deleteError
}
}
}
|
