fix: serve media again by unsetting download-proxy and scoping Host per request

Two independent faults made every image fail while pages still rendered.

config.example.json shipped download-proxy=http://127.0.0.1:8080. Only media
fetches go through that proxy — pages reach DeviantArt via devianter on the
default transport — so when nothing listens there, images 502 and the rest of
the page looks fine. In a scratch container 127.0.0.1 is the container itself,
so the default could never work under Docker. Unset it and document that it must
stay empty unless an operator really runs a proxy.

Host was a package global reassigned by every request, so a concurrent request
could overwrite it mid-render and emit URLs on another origin's host and port.
The instance's own default-src 'self' CSP then blocked those images. Thread the
request's host through skunkyart instead, and take it as an explicit argument in
URLBuilder, ParseMedia, ParseDescription, BuildUserPlate and
ConvertDeviantArtURLToSkunkyArt. Feeds keep their absolute URLs.

Also start RefreshInstances after ExecuteConfig rather than before it: the
goroutine read CFG while json.Unmarshal was writing it (a race the detector
flags), and its fetch escaped both the throttle and the configured User-Agent.

Verified: 300 concurrent requests with distinct Host headers now round-trip
their own host (was 1 leak per 300), go test -race is clean, and
cache+proxy both enabled serves 200 image/jpeg cold and from cache.

1 files changed, 5 insertions, 1 deletions

diff --git a/main.go b/main.go
index c57ad7a..7a5a63e 100755
--- a/main.go
+++ b/main.go
@@ -11,7 +11,6 @@ import (
 func main() {
 	app.Release.Version = "1.3.2"
 	app.Release.Description = "Two API endpoints and template embedding into binary"
-	go app.RefreshInstances()
 
 	app.ExecuteCommandLineArguments()
 	app.ExecuteConfig()
@@ -21,6 +20,11 @@ func main() {
 	// can't exhaust the process or get our egress IP banned by CloudFront/WAF.
 	app.InstallDAThrottle()
 
+	// Only once the config is loaded and the throttle installed: this fetches over
+	// the network, so starting it earlier both raced ExecuteConfig's writes to CFG
+	// and let the request escape the throttle and the configured User-Agent.
+	go app.RefreshInstances()
+
 	go func() {
 		for {
 			err := devianter.UpdateCSRF()